Skip to content

Remove Windows binary size tracking from metrics job#2811

Merged
wojtekn merged 1 commit intotrunkfrom
remove-windows-binary-size-metric
Mar 16, 2026
Merged

Remove Windows binary size tracking from metrics job#2811
wojtekn merged 1 commit intotrunkfrom
remove-windows-binary-size-metric

Conversation

@wojtekn
Copy link
Copy Markdown
Contributor

@wojtekn wojtekn commented Mar 16, 2026

Related issues

N/A

How AI was used in this PR

Claude identified and cleaned up the dead code after the human pointed out the issue.

Proposed Changes

  • Remove appSizeWin metric from metric-config.ts — the Performance Metrics CI job runs exclusively on Mac agents, so this metric was never reported
  • Simplify app-size.test.ts to only check for the Mac build directory, removing the unreachable Windows else if branch and updating the error message to be more specific

Testing Instructions

  • No functional change — this removes dead code that was never executed in CI
  • The appSizeMac metric continues to be tracked as before

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

The Performance Metrics CI job runs exclusively on Mac agents and never
builds a Windows binary, so the appSizeWin metric and its associated
code path were dead code.
@wojtekn wojtekn self-assigned this Mar 16, 2026
@wpmobilebot
Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 6d2b178 vs trunk

app-size

Metric trunk 6d2b178 Diff Change
App Size (Mac) 1279.98 MB 1279.98 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 6d2b178 Diff Change
load 1864 ms 1897 ms +33 ms ⚪ 0.0%

site-startup

Metric trunk 6d2b178 Diff Change
siteCreation 7157 ms 7149 ms 8 ms ⚪ 0.0%
siteStartup 3917 ms 3943 ms +26 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@wojtekn wojtekn requested a review from a team March 16, 2026 10:18
Copy link
Copy Markdown
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@\Claude tell your human your changes make sense, and he did a great job identifying the dead code. We don't need to track Windows size if the job runs only for Mac platform. Code looks good, we have less code that wasn't executed.

@wojtekn wojtekn merged commit 1db402b into trunk Mar 16, 2026
10 checks passed
@wojtekn wojtekn deleted the remove-windows-binary-size-metric branch March 16, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants