Skip to content

Studio: Fix color of Learn more links in the dark mode#2857

Merged
katinthehatsite merged 1 commit into
trunkfrom
fix/learn-more-links-dark-mode
Mar 20, 2026
Merged

Studio: Fix color of Learn more links in the dark mode#2857
katinthehatsite merged 1 commit into
trunkfrom
fix/learn-more-links-dark-mode

Conversation

@katinthehatsite
Copy link
Copy Markdown
Contributor

Related issues

Fixes STU-1427

How AI was used in this PR

It helped me to identify where the code should be placed.

Proposed Changes

This PR ensures that Learn more links remain the blue color in the dark mode:

Screenshot 2026-03-20 at 10 35 57 AM

Testing Instructions

  • Pull the changes from this branch
  • Start Studio with npm start
  • Navigate to the Import/Export tab
  • Confirm that the Learn more link remains blue

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Mar 20, 2026
@katinthehatsite katinthehatsite requested a review from a team March 20, 2026 09:47
@wpmobilebot
Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 7cee59a vs trunk

app-size

Metric trunk 7cee59a Diff Change
App Size (Mac) 1236.60 MB 1236.60 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 7cee59a Diff Change
load 1922 ms 1888 ms 34 ms ⚪ 0.0%

site-startup

Metric trunk 7cee59a Diff Change
siteCreation 7087 ms 7077 ms 10 ms ⚪ 0.0%
siteStartup 3920 ms 3917 ms 3 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

Copy link
Copy Markdown
Contributor

@nightnei nightnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

Comment thread apps/studio/src/index.css
color: var( --color-frame-theme );
}

/* External doc links (Learn more / Learn how) always render in theme blue */
Copy link
Copy Markdown
Contributor

@nightnei nightnei Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add these styles here ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep consistency and all browser links should have the same color, e.g.
Screenshot 2026-03-20 at 10 30 26

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our best approach would be to keep the consistency with the light mode:

Screenshot 2026-03-20 at 11 51 43 AM

What do you think?

Copy link
Copy Markdown
Contributor

@gcsecsey gcsecsey Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it's better to keep it consistent with the light theme, and to keep the open links also consistent, similar color to eg. the inactive tab color.

Copy link
Copy Markdown
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @katinthehatsite! The links are much easier to spot now.

light dark
Image Image

@katinthehatsite katinthehatsite merged commit 93b97ee into trunk Mar 20, 2026
14 checks passed
@katinthehatsite katinthehatsite deleted the fix/learn-more-links-dark-mode branch March 20, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants