Add archiver patches back to fix following symlinks on export#3060
Open
Add archiver patches back to fix following symlinks on export#3060
Conversation
Collaborator
📊 Performance Test ResultsComparing fe1f002 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
The @types/archiver patches added followSymlinks to CoreOptions, but this is unnecessary — ARCHIVER_OPTIONS in constants.ts uses plain object inference so followSymlinks is never checked against CoreOptions. The CLI patch also broke CI because install:bundle uses --omit=dev, meaning @types/archiver is absent when patch-package runs.
epeicher
approved these changes
Apr 10, 2026
Contributor
epeicher
left a comment
epeicher
left a comment
There was a problem hiding this comment.
Thanks @wojtekn for adding those! I have tested running npm install and running npm start and I don't see any errors. I have tested exporting a site with symlinks and I see the symlinked plugin folder in the new site. I have added a commit that removes the types @types+archiver+7.0.0.patch because that patch was not necessary and it was also breaking the CI. Once the CI passes this could be merged. LGTM!
| Symlink site | Imported previously exported site |
|---|---|
 |
 |
The @types/archiver patches added followSymlinks to CoreOptions, but @types/archiver@7 dropped followSymlinks from CoreOptions (it's still supported at runtime). The CLI patch also broke CI because install:bundle uses --omit=dev, meaning @types/archiver is absent when patch-package runs. Restore the `as archiver.ArchiverOptions` casts at call sites.
…dio into add-archiver-patches-back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
I used AI to regenerate patches and revert unnecessary changes from the previous PR.
Proposed Changes
I propose adding patches that add follow-symlinks option to archiver.
Testing Instructions
Pre-merge Checklist