Support landingPage Blueprint property#3107
Merged
Conversation
3275672 to
f673dab
Compare
Collaborator
📊 Performance Test ResultsComparing 8b8368e vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
gcsecsey
approved these changes
Apr 17, 2026
Contributor
gcsecsey
left a comment
There was a problem hiding this comment.
Thanks for working on this @bcotrim! 🙌
The changes LGTM and the notices are now removed:
| Before | After |
|---|---|
![]() |
![]() |
I tested this using the friends-cors blueprint, and found that all links to the frontend of the site (header, site-menu, content-tab-overview) open the correct URL:
| Link | Page |
|---|---|
| Open WP Admin | ![]() |
| Open site | ![]() |
I also tested using the chat-to-blog blueprint, which adds a landingPage within wp-admin.
| Link | Page |
|---|---|
| Open WP Admin | ![]() |
| Open site | ![]() |
I also tested the CLI opening the langingPage URL as described. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Related issues
How AI was used in this PR
Implemented with Claude Code. Reviewed the diff and ran lint/typecheck/tests locally before pushing.
Proposed Changes
Studio used to strip
landingPagefrom Blueprints. Now it persists it on the site and uses it as the default target for "Open site" actions in the desktop app and CLI.landingPagefrom the unsupported-properties list (no more warning on import).normalizeLandingPage()helper: strips host from absolute URLs, ensures a leading slash, treats empty/non-strings as unset.landingPage?: stringonsiteDetailsSchema,StoppedSiteDetails, and captured it at CLI site creation.openSiteURLfalls back to the storedlandingPagewhen no explicit path is passed. Forces auto-login in that case so admin landing pages work instead of bouncing to WP login.openSiteInBrowseruseslandingPageas the auto-login redirect target, falling back to/wp-admin/for sites without one.Cleanup
With
landingPagegone, both unsupported-feature lists became empty. This PR also removes all the now-dead machinery — scanner, filter,BlueprintValidationWarning, warning UI, and the plumbing across ~8 files. -359 lines in a dedicated commit. Git history has it if we ever need to reintroduce.Testing Instructions
Manual — Desktop
Import a Blueprint with
"landingPage": "/wp-admin/post-new.php". Verify no "unsupported feature" warning, then click "Open local site" from each entry point — header, site context menu, overview thumbnail, import/export tab. All should auto-login and land on the New Post screen. "WP Admin" and "Site Editor" buttons should still honor their explicit paths. Sites withoutlandingPageshould still open the homepage.Manual — CLI
Browser should auto-login and land on the Blueprint's
landingPage.Pre-merge Checklist