apps/ui: Add active site icons to the UI#3266
Merged
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing 8bcac07 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Adds a `wp studio get-site-icon` mu-plugin command that reports the icon attachment's path. SiteServer caches the host path in app.json and the IPC boundary reads the file as a data URL so the renderer can show it in the sidebar `SiteIcon`. Falls back to the procedural mesh gradient when no icon is configured or the image fails to load. Backfills icons for sites already running at app launch since they never trigger the cli-events-subscriber's running-transition branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
youknowriad
force-pushed
the
add-site-icon-sidebar
branch
from
a6358eb to
dea8b47
Compare
youknowriad
commented
May 3, 2026
youknowriad
commented
May 3, 2026
youknowriad
commented
May 3, 2026
youknowriad
commented
May 3, 2026
Mirrors the loadThemeDetails / persistThemeDetails pair: re-add persistSiteIcon and call it from a new loadSiteIcon IPC handler invoked alongside loadThemeDetails after createSite and startServer. The cli-events-subscriber stays in-memory only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
youknowriad
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds active site icons to the sidebar list and collapsed site header so the current site remains identifiable in compact layouts.
Proposed Changes
SiteIconcomponent for compact site identity in UI chrome.Testing Instructions
Automated Checks
npx eslint --fix apps/ui/src/components/session-view/index.tsx apps/ui/src/components/session-view/style.module.css apps/ui/src/components/site-dropdown/dropdown-trigger.module.css apps/ui/src/components/site-dropdown/dropdown-trigger.tsx apps/ui/src/components/site-dropdown/index.tsx apps/ui/src/components/site-list/index.tsx apps/ui/src/components/site-list/style.module.css apps/ui/src/components/site-settings-view/index.tsx apps/ui/src/components/site-icon/index.tsx apps/ui/src/components/site-icon/style.module.cssnpm run typechecknpm test -- --passWithNoTests apps/ui/src/components/site-list apps/ui/src/components/site-dropdown apps/ui/src/components/session-view apps/ui/src/components/site-settings-viewPre-merge Checklist