Lint scripts from the root config

[mokagio]

How AI was used in this PR

Used Codex to implement the script updates, run local verification, and surface the pre-existing script lint issues that had to be fixed once scripts/ was added to the root lint target.
I reviewed the resulting diff and verification output before opening this PR.

Proposed Changes

While working with AI in this repo for the CI automation, I run into linting inconsistencies in the scripts folder a few times. This PR propose to treat the scripts as first-class linting citizens, and addresses any issue found in them.

• Bring scripts/ under the root npm run lint target.
• Align the ESM scripts with the repo's import.meta.dirname preference and add a guardrail against reintroducing __dirname in scripts/**/*.mjs.
• Fix the pre-existing script lint issues that surfaced once scripts/ was linted, while keeping existing CommonJS script entrypoints valid.

Testing Instructions

• Run npm run lint
• Run npm run typecheck
• Run env FILE_ARCHITECTURE=x64 WINDOWS_CODE_SIGNING_CERT_PASSWORD=fake node scripts/package-appx.mjs and confirm it gets past module loading and stops at the expected missing Windows SDK check.
• Run env FILE_ARCHITECTURE=x64 node scripts/make-dmg.mjs after a full install and confirm it reaches appdmg; with npm install --ignore-scripts it currently stops earlier on the missing native volume.node dependency.

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[Copilot]

Pull request overview

This PR makes the repository’s scripts/ directory part of the root ESLint target and updates affected scripts/config so they lint cleanly and follow the repo’s ESM path-resolution conventions.

Changes:

• Include scripts/ in the root npm run lint target.
• Update multiple .mjs scripts to use import.meta.dirname instead of fileURLToPath(import.meta.url)/__dirname.
• Add ESLint overrides for scripts/**/* (allow require in CommonJS scripts; restrict __dirname/__filename usage in ESM scripts) and fix surfaced lint issues (e.g., hasOwnProperty, floating promises).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
scripts/start-new-ui.mjs	Switch root path resolution to import.meta.dirname.
scripts/prepare-dev-build-version.mjs	Reorder imports to satisfy lint ordering.
scripts/package-in-isolation.ts	Use safe Object.prototype.hasOwnProperty.call check.
scripts/package-appx.mjs	Remove local __dirname and use import.meta.dirname for paths.
scripts/make-dmg.mjs	Replace execSync string invocation with execFileSync + import.meta.dirname paths.
scripts/download-node-binary.ts	Fix lint ordering and mark async entrypoint call with void.
scripts/download-available-site-translations.mjs	Use import.meta.dirname for output path resolution.
scripts/azure-signing.cjs	Reformat env var list to satisfy lint/formatting.
scripts/azure-sign-hook.js	Remove per-file eslint disable now covered by ESLint override.
package.json	Add scripts to the root lint command target list.
eslint.config.mjs	Add scripts-specific overrides and ESM guardrails for __dirname/__filename.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[wpmobilebot]

📊 Performance Test Results

Comparing f2c750c vs trunk

app-size

Metric	trunk	f2c750c	Diff	Change
App Size (Mac)	1511.23 MB	1511.23 MB	+0.00 MB	⚪ 0.0%

site-editor

Metric	trunk	f2c750c	Diff	Change
load	1822 ms	1802 ms	20 ms	⚪ 0.0%

site-startup

Metric	trunk	f2c750c	Diff	Change
siteCreation	8076 ms	8079 ms	+3 ms	⚪ 0.0%
siteStartup	4942 ms	4961 ms	+19 ms	⚪ 0.0%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

[wojtekn]

Looks good.