[WIP] Remove php-server-child and manage native PHP child processes directly#3359
Closed
fredrikekelund wants to merge 16 commits intotrunkfrom
Closed
[WIP] Remove php-server-child and manage native PHP child processes directly#3359fredrikekelund wants to merge 16 commits intotrunkfrom
php-server-child and manage native PHP child processes directly#3359fredrikekelund wants to merge 16 commits intotrunkfrom
Conversation
Collaborator
📊 Performance Test ResultsComparing 5fbdb67 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
Author
|
I embarked on this thinking that the E2E tests on Windows were maybe having trouble killing the PHP grandchild processes. However, ultimately, that wasn't the case. Some parts of this implementation are good, but we could go even further and achieve a clearer system if we only had to deal with a single runtime type. To that end, I'll close this PR for now and revisit this in a month or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
native-phpE2E tests pass on Windows #3343. Includes the changes from that PRHow AI was used in this PR
Codex was used extensively to drive the implementation of this PR.
Proposed Changes
Important
Despite not being a draft, this PR isn't fully ready for review yet. That's because E2E tests won't trigger on CI if it's a draft.
This is a large refactor that makes it so the process manager daemon only has to deal with direct child processes. With the previous approach,
php-server-child.tswould spawn PHP child processes, which became grandchildren of the process manager daemon. These are not as simple to manage as direct child processes.With this PR, consumers tell the process manager daemon to spawn a type of process rather than a specific JS script. The process types have separate implementations that conform to a
ManagedProcessinterface.Testing Instructions
TBD
Pre-merge Checklist