Fix .deb policykit dependency for Debian trixie / Kali#3364
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing e3e3b27 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
ivan-ottinger
approved these changes
May 11, 2026
Contributor
ivan-ottinger
left a comment
There was a problem hiding this comment.
Good catch! The change looks good! I am currently building the app and will test it, but already approving the PR as I don't think there will be any issues.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related issues
How AI was used in this PR
Claude Code applied the one-line dependency change proposed in the Linear issue and rewrote the inline comment to explain why the alternative is needed. I verified the build install on both Ubuntu 24.04 and Kali myself.
Proposed Changes
.debDependsentry frompolicykit-1topkexec | policykit-1so the package resolves on both legacy (Ubuntu 24.04 / older Debian) and current (Debian trixie / Kali rolling) polkit packaging. Both alternatives ultimately provide thepkexecbinary that@vscode/sudo-promptneeds for hosts-file writes.apps/studio/forge.config.tsto document the split and why the alternative is required.Testing Instructions
.deb:npm run makeon Linux.sudo apt install ./out/make/deb/**/studio_*.deb— should resolvepolicykit-1and install cleanly. ✅ Verified.pkexecand install cleanly (previously failed withDepends: policykit-1 but it is not installable). ✅ Verified.Pre-merge Checklist