Generate CLI passwords without window#3416
Closed
chubes4 wants to merge 1 commit into
Closed
Conversation
Collaborator
📊 Performance Test ResultsComparing 7290bb0 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
Author
|
Closing this in favor of fixing the root cause upstream in The Studio failure is real and tracked in #3417, with Homeboy evidence showing This PR worked around the issue by replacing Studio's package usage with local password generation, but that would fork package behavior inside Studio and leave other Node consumers broken. The better path is:
Superseded by the upstream-first fix path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
@automattic/generate-passwordwrapper usage with an equivalent runtime-neutral password generator.globalThis.crypto.getRandomValues()so password generation works in Node CLI and browser-capable runtimes.generatePassword()andcreatePassword()APIs.Testing Instructions
npx vitest run tools/common/lib/tests/passwords.test.tsnpm run lint -- tools/common/lib/passwords.tsAI assistance
window is not definedfailure and drafting the small runtime-neutral password generator patch. Chris remains responsible for review and merge.