Revert "Distribute Linux dev builds to AppsCDN" (#3363)#3462
Merged
Conversation
This reverts commit 4dd82c8.
This was referenced May 13, 2026
Merged
ivan-ottinger
added a commit
that referenced
this pull request
May 14, 2026
## Related issues Unblocks [#3464](#3464) (Linux dev build distribution re-apply). ## How AI was used in this PR AI-assisted: ran the `bundle update --conservative` command, drafted this PR body. Author reviewed. ## Proposed Changes Bumps `fastlane-plugin-wpmreleasetoolkit` to v14.6.0 to pick up Linux platform support added upstream in [wordpress-mobile/release-toolkit#720](wordpress-mobile/release-toolkit#720). Without this, the `upload_build_to_apps_cdn` action in Studio's fastlane lanes rejects `'Linux - x64'` and `'Linux - ARM64'` as invalid platform values client-side, which is what failed [build #16073](https://buildkite.com/automattic/studio/builds/16073) and prompted the revert in [#3462](#3462). The lockfile changes are limited to the targeted gem and its required deps (used `bundle update --conservative`): the gem bump itself, removal of `activesupport` and its transitive deps (release-toolkit dropped that dep in 14.3.1), and bumps for `aws-sdk-core`/`kms`/`s3` which release-toolkit's google-cloud-storage requires. `nokogiri` requirement also tightens (14.6.0 raised its minimum). ## Testing Instructions CI passing is the test. Existing macOS/Windows distribution behavior is unchanged — the new gem adds platform values without modifying existing ones. ## Pre-merge Checklist - [ ] Have you checked for TypeScript, React or other console errors? - [ ] CI is green.
ivan-ottinger
added a commit
that referenced
this pull request
May 15, 2026
## Related issues Re-applies #3363 after it was reverted in #3462. Blocked on the upstream fastlane-plugin gap landing — see [RSM-3058](https://linear.app/a8c/issue/RSM-3058/add-linux-to-upload-build-to-apps-cdn-platform-allowlist-in-release) and [wordpress-mobile/release-toolkit#720](wordpress-mobile/release-toolkit#720). ## How AI was used in this PR AI-assisted: re-applied the original change as a revert-of-revert commit, drafted this PR body explaining the dependency chain. Author reviewed. ## Why this PR exists The original #3363 wired Linux DEBs into the existing dev-distribution flow (fastlane + Buildkite). On merge it caused trunk's `Distribute Dev Builds` step to fail because the `upload_build_to_apps_cdn` fastlane action has a **client-side platform allowlist** that doesn't include Linux. We reverted in #3462 to restore trunk health. The upstream fix is in flight at [wordpress-mobile/release-toolkit#720](wordpress-mobile/release-toolkit#720), which adds `'Linux - x64'` and `'Linux - ARM64'` to the action's `VALID_PLATFORMS` constant. Once that PR merges and a new gem version is released, we can re-apply the original Studio-side change and ship Linux dev distribution. ## What this PR contains Pure re-apply of #3363 (revert-of-revert commit). Two files: - `.buildkite/pipeline.yml`: adds `- step: dev-linux` to `Distribute Dev Builds`'s `depends_on` and `buildkite-agent artifact download "*.deb" .` to its command block. - `fastlane/Fastfile`: adds the `linux_deb_path` helper and the `release_tag.nil?` block with the two Linux entries (`linux_x64_deb`, `linux_arm64_deb`). No changes to `Gemfile` / `Gemfile.lock` here — that bump comes as a separate, smaller PR landed **before** this one (see merge order below). ## Merge order (important) 1. [wordpress-mobile/release-toolkit#720](wordpress-mobile/release-toolkit#720) merges → release-toolkit team cuts a new gem release. 2. **Separate small PR** bumps Studio's `Gemfile.lock` to the new gem version (via `bundle update fastlane-plugin-wpmreleasetoolkit`). The `Gemfile` pessimistic constraint (`~> 14.2`) already accepts the new minor version, so only the lock file changes. 3. This PR is marked ready for review, CI runs against the bumped gem, reviewed, merged. 4. Next trunk build's `Distribute Dev Builds` should now succeed for all three platforms. Until step 2 lands, this PR's CI will keep hitting the same plugin-validation error as #3363 did. It stays draft until then. ## Out of scope - **Release pipeline Linux integration ([RSM-2587](https://linear.app/a8c/issue/RSM-2587/wire-linux-into-the-release-pipeline)).** A separate PR will wire Linux into `.buildkite/release-build-and-distribute.yml` and lift the `release_tag.nil?` gate from `Fastfile`. Conceptually expands the same Linux distribution work to release-time uploads, but it's a different pipeline file and a meaningfully different blast radius, so it deserves its own PR. ## Testing Instructions Once the gem bump PR lands and this is marked ready: 1. Push a commit (or let CI re-run on the existing commit) and confirm `Lint`, `Unit Tests`, `E2E Tests`, `Performance Metrics` all stay green. 2. After merge, watch the first trunk build's `Distribute Dev Builds` step. Should succeed and the log should contain CDN URLs for both Linux entries (`Linux - x64`, `Linux - ARM64`) alongside the existing Mac and Windows uploads. 3. Optionally `curl -IL` one of the returned Linux CDN URLs to confirm it serves the `.deb`. ## Pre-merge Checklist - [ ] Have you checked for TypeScript, React or other console errors? - [ ] Gemfile.lock bump PR is merged. - [ ] Trunk's `Distribute Dev Builds` step succeeds end-to-end after this lands and reports CDN URLs for both Linux entries. Co-authored-by: Rahul Gavande <rahul.gavande@automattic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Reverts #3363. Restoring this once the upstream fix lands in the
wordpress-mobile/release-toolkitplugin.How AI was used in this PR
AI-assisted: diagnosed the post-merge failure from the Buildkite log, identified the gap in the fastlane plugin's platform allowlist, and drafted this revert. Author reviewed.
Why we're reverting
After #3363 merged, the next trunk build's
Distribute Dev Buildsstep (Buildkite #16073) failed with:The
upload_build_to_apps_cdnfastlane action (from thewordpress-mobile/release-toolkitgem, pinned at~> 14.2) has a client-side allowlist baked into itsVALID_PLATFORMSconstant (lib/fastlane/plugin/wpmreleasetoolkit/actions/common/upload_build_to_apps_cdn.rb:31-43). That list doesn't include'Linux - x64'or'Linux - ARM64', so the action rejects our call before it ever reaches WPCOM.The WPCOM-side allowlist updates (the enum + extension MIME types) are landed and correct — they handle the server-side validation. But the client-side validation in the fastlane plugin is a separate codebase that also needs to be updated. We missed that gap before merging.
Impact while #3363 was on trunk:
buildkite_annotatesummary fired.Distribute Dev Buildsstep shows red despite Mac/Windows being in CDN — confusing for anyone watching trunk.Reverting restores the clean Mac/Windows distribution flow until the plugin gap is fixed upstream.
Proposed Changes
Reverts the two-file change from #3363:
.buildkite/pipeline.yml: dropsdev-linuxfromDistribute Dev Builds'sdepends_onand removes the*.debartifact download.fastlane/Fastfile: removes thelinux_deb_pathhelper, therelease_tag.nil?block adding Linux entries toupdate_builds, and the related comment.Next steps after this lands
wordpress-mobile/release-toolkitadding'Linux - x64'and'Linux - ARM64'toVALID_PLATFORMSinupload_build_to_apps_cdn.rb. Precedent: their PR Studio: Display spinner when the site is being pulled #672 added'Microsoft Store - x64'and'Windows - x64'to the same array.Gemfileto that version.Testing Instructions
Distribute Dev Buildsstep succeeds and thebuildkite_annotatesummary lists Mac and Windows (and only those) in the "🔗 Build available for ..." message.Pre-merge Checklist
Distribute Dev Buildsstep succeeds again after this lands.