Handle existing PHP binary CDN builds#3530
Merged
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing 7455c52 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Updates PHP CLI binary CDN metadata after a successful Apps CDN upload. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Codex assisted with the implementation, fixture checks, and PR summary. I reviewed the diff and verification output.
Proposed Changes
tools/common/lib/php-binary-cdn-metadata.json.Testing Instructions
Optional end-to-end workflow test
handle-php-binary-existing-versions.php_version: a real patch version to upload, e.g.8.4.21spc_ref:2.8.5debug:falseupload_to_apps_cdn:trueapps_cdn_visibility:internalPublish Apps CDN artifactsjob to finish.update-php-cli-metadata-<version>-<run_id>was pushed.handle-php-binary-existing-versions.tools/common/lib/php-binary-cdn-metadata.jsonwith the CDN URLs and SHA-256 hashes.Pre-merge Checklist