Skip to content

Fix type error in default PHP migration by narrowing version to native-supported set#3561

Merged
nightnei merged 1 commit into
trunkfrom
fixPhoVersionLint
May 20, 2026
Merged

Fix type error in default PHP migration by narrowing version to native-supported set#3561
nightnei merged 1 commit into
trunkfrom
fixPhoVersionLint

Conversation

@nightnei
Copy link
Copy Markdown
Contributor

How AI was used in this PR

AI helped to fix it

Proposed Changes

Screenshot 2026-05-20 at 16 42 14 - Narrow DEFAULT_PHP_VERSION via resolveNativePhpVersion() before passing it to getConfiguredPhpBinaryVersion() in apps/cli/migrations/06-install-bundled-default-php.ts and its test, - No runtime behavior change — the default value ("8.4") is already a native-supported version; this only satisfies the type checker.

Testing Instructions

Code review

@nightnei nightnei requested review from a team and bcotrim May 20, 2026 15:42
@nightnei nightnei enabled auto-merge (squash) May 20, 2026 15:50
@wpmobilebot
Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing b89e8e4 vs trunk

app-size

Metric trunk b89e8e4 Diff Change
App Size (Mac) 1327.01 MB 1327.01 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk b89e8e4 Diff Change
load 1523 ms 1519 ms 4 ms ⚪ 0.0%

site-startup

Metric trunk b89e8e4 Diff Change
siteCreation 8573 ms 8565 ms 8 ms ⚪ 0.0%
siteStartup 4931 ms 4929 ms 2 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@nightnei nightnei merged commit 6e4178f into trunk May 20, 2026
11 checks passed
@nightnei nightnei deleted the fixPhoVersionLint branch May 20, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants