Skip to content

Invert dark mode tooltip colors#3981

Open
shaunandrews wants to merge 5 commits into
trunkfrom
stu-1884-use-pure-black-tooltip-background-in-dark-mode
Open

Invert dark mode tooltip colors#3981
shaunandrews wants to merge 5 commits into
trunkfrom
stu-1884-use-pure-black-tooltip-background-in-dark-mode

Conversation

@shaunandrews

@shaunandrews shaunandrews commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

  • In dark mode, tooltips now use an inverted treatment: white background with black text, improving contrast against Studio's dark UI.
  • The local @wordpress/ui patch exposes tooltip background and foreground CSS custom properties, so Studio can control tooltip colors without brittle generated selectors or wrapper-only workarounds.
image image

Testing Instructions

  • Run ENABLE_AGENTIC_UI=true npm start.
  • Switch Studio to dark mode, then hover icon-only controls that render tooltips.
  • Confirm tooltips use a white background with black text in dark mode.
  • Switch to light mode and confirm the existing light-mode tooltip colors are unchanged.

@shaunandrews shaunandrews marked this pull request as ready for review June 30, 2026 03:14

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, I have one note regarding the testing instructions:

Image

I had to first run:

rm -rf node_modules && npm install

to ensure that the patch was installed correctly. In case this helps other testers

@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing b16ff35 vs trunk

app-size

Metric trunk b16ff35 Diff Change
App Size (Mac) 1315.63 MB 1315.63 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk b16ff35 Diff Change
load 1102 ms 764 ms 338 ms 🟢 -30.7%

site-startup

Metric trunk b16ff35 Diff Change
siteCreation 6510 ms 6527 ms +17 ms ⚪ 0.0%
siteStartup 6552 ms 6557 ms +5 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants