Fix /me/sites filtering and environment labels, keeping Pressable sites#4064
Draft
bcotrim wants to merge 2 commits into
Draft
Fix /me/sites filtering and environment labels, keeping Pressable sites#4064bcotrim wants to merge 2 commits into
bcotrim wants to merge 2 commits into
Conversation
Collaborator
📊 Performance Test ResultsComparing 140803e vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
filtersvalue.How AI was used in this PR
AI (Claude) extracted the change from #3941, traced the Pressable regression, and validated the corrected
filtersvalue against Calypso/Jetpack Cloud source; lint, typecheck, and sync tests were run locally. Manually reviewed.Proposed Changes
/me/sitesrequests have always sentfilter=(singular), which the API silently ignores — no server-side filtering ever happened, and non-syncable site types were only weeded out client-side.filters=jetpack,atomic,wpcomparam — the same set Jetpack Cloud sends in production. Includingjetpackis what keeps Pressable (Jetpack-connected) sites in every picker; the earlierfilters=atomic,wpcomattempt in Agentic UI: Site Creation #3941 dropped them, which is the regression that got it pulled out of that PR.environment_type=stagingare now labeled Staging even when their parent production site isn't in the fetched list (previously they showed as Production).Testing Instructions
atomic,wpcomvalue).studio pull/studio pushagainst the Pressable site still resolve it.Pre-merge Checklist