More safety checks around IPC communication#849
Merged
Conversation
wojtekn
approved these changes
Jan 28, 2025
Contributor
wojtekn
left a comment
wojtekn
left a comment
There was a problem hiding this comment.
The code change looks clear, and it's more readable now.
I smoke tested different Studio features and haven't noticed any issues.
bgrgicak
pushed a commit
that referenced
this pull request
Jan 29, 2025
* WIP * withMainWindow -> getMainWindow * Refinements
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
With the help of some AI debugging in Sentry, I determined that https://github.com/Automattic/dotcom-forge/issues/10346 seems to be happening because we send IPC messages to windows that have been destroyed. This PR adds some additional
isDestroyedchecks to mitigate that (see 0ae3042).I also took the opportunity to refactor
withMainWindowinto a function that returns a promise instead. There's really no reason for it to accept a callback, so this helps keep our code clean and simple.Testing Instructions
Smoke test the app. Ensure that the About menu, the settings, and the fullscreen view work as expected.
Pre-merge Checklist