fix(test): stop ProcessTreeProbe from leaking orphaned fake-codex processes#98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The turn-timeout side-output test used a
ProcessTreeProbedouble that recorded the cleanup call but never ran it, so each test run orphaned afake-codexbusy loop that pinned a CPU core indefinitely.TL;DR
Make the test's process-tree cleanup double actually terminate the spawned process tree instead of no-op'ing it.
Summary
ProcessTreeProbe.terminate_port_descendants/1now delegates to the realSymphonyElixir.ProcessTreeafter sending its verification message.bash -> /bin/sh fake-codexbusy loop (while true; sleep 0.01) from leaking as an orphan on every run of the turn-timeout side-output test.{:process_tree_cleanup, true}assertion intact; only the dropped side effect is restored.Alternatives
on_exitsweep to kill stray fake-codex processes: treats the symptom, not the missing cleanup in the double.sleep 0.5): reduces but does not remove the leak.Test Plan
make allmix test test/symphony_elixir/app_server_test.exs:1864thenpgrep -fl symphony-elixir-app-server-turn-timeoutreturns no orphaned processes