Skip to content

Conversation

@rinatkhaziev
Copy link
Contributor

Description

Elasticsearch's default behavior is to claim 50% available memory, which is undesirable. This PR introduces hard cap of 1GB.

It can be overridden via the .lando.local.yml, like so

services:
  elasticsearch:
    services:
      deploy:
        resources:
          limits:
            memory: 1GB

Changelog Description

Changed

  • Local Dev Env: Elasticsearch container memory is capped at 1GB now

Pull request checklist

New release checklist

Steps to Test

Add memory limit for Elasticsearch service in Lando config
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets a hard memory limit of 1GB for the Elasticsearch container to prevent it from consuming excessive resources (50% of available memory by default). The change also removes the experimental label from PHP 8.4 and bumps the development environment version.

  • Added memory limit configuration for Elasticsearch container
  • Updated PHP 8.4 label from experimental to stable
  • Bumped dev environment version to 2.3.1

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
assets/dev-env.lando.template.yml.ejs Added deploy configuration with 1GB memory limit for Elasticsearch service
src/lib/constants/dev-environment.ts Removed experimental label from PHP 8.4 and incremented version number

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

@rinatkhaziev rinatkhaziev changed the title Set memory limit for Elasticsearch to 1GB [PLTFRM-1781] Set memory limit for Elasticsearch to 1GB Oct 15, 2025
deploy:
resources:
limits:
memory: 1GB
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a sane default value but probably it may not be enough for larger apps.

@sjinks sjinks merged commit c14b9dd into trunk Oct 28, 2025
19 checks passed
@sjinks sjinks deleted the update/es-container-memory-limit branch October 28, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants