-
Notifications
You must be signed in to change notification settings - Fork 19
[PLTFRM-1781] Set memory limit for Elasticsearch to 1GB #2593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add memory limit for Elasticsearch service in Lando config
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR sets a hard memory limit of 1GB for the Elasticsearch container to prevent it from consuming excessive resources (50% of available memory by default). The change also removes the experimental label from PHP 8.4 and bumps the development environment version.
- Added memory limit configuration for Elasticsearch container
- Updated PHP 8.4 label from experimental to stable
- Bumped dev environment version to 2.3.1
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| assets/dev-env.lando.template.yml.ejs | Added deploy configuration with 1GB memory limit for Elasticsearch service |
| src/lib/constants/dev-environment.ts | Removed experimental label from PHP 8.4 and incremented version number |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
| deploy: | ||
| resources: | ||
| limits: | ||
| memory: 1GB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a sane default value but probably it may not be enough for larger apps.



Description
Elasticsearch's default behavior is to claim 50% available memory, which is undesirable. This PR introduces hard cap of 1GB.
It can be overridden via the
.lando.local.yml, like soChangelog Description
Changed
Pull request checklist
New release checklist
Steps to Test