Conversation
|
Dependency ReviewThe following issues were found:
License Issuespackage.json
OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Pull request overview
This PR updates dependency pins/lockfile entries to bring lando (via a newer lando-cli commit) and protobufjs (and related @protobufjs/* packages) to newer versions, along with updated transitive dependencies reflected in the npm shrinkwrap.
Changes:
- Bump
landoto commit78d382fc…inpackage.jsonand lock it innpm-shrinkwrap.json. - Update shrinkwrapped transitive dependencies including
axios,dockerode,follow-redirects,jsonfile, andprotobufjs(+@protobufjs/*). - Remove
uuidas a transitive dependency (no longer present in the shrinkwrap).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates the lando dependency to a newer GitHub commit. |
| npm-shrinkwrap.json | Locks updated dependency graph for the new lando commit and protobufjs bump; removes uuid entry. |
Files not reviewed (1)
- npm-shrinkwrap.json: Language not supported
| "version": "5.0.0", | ||
| "resolved": "https://registry.npmjs.org/dockerode/-/dockerode-5.0.0.tgz", | ||
| "integrity": "sha512-C52mvJ+7lcyhWNfrzVfFsbTrBfy/ezE9FGEYLpu17FUeBcCkxERk9nN7uDl/478ynDiQ4U+5DbQC2vENHkVEtQ==", | ||
| "dev": true, | ||
| "license": "Apache-2.0", | ||
| "dependencies": { |
There was a problem hiding this comment.
dockerode is imported and used at runtime (e.g. src/lib/dev-environment/dev-environment-lando.ts imports dockerode), but in package.json it is listed under devDependencies. This relies on dockerode being present transitively (currently via lando) and can break if the transitive tree changes or consumers install without dev deps. Move dockerode to dependencies (and regenerate the shrinkwrap) so the runtime requirement is explicit.



This pull request updates several dependencies in the project, primarily focusing on the
landopackage and its related dependencies. The main goal is to upgradelandoto a newer commit, which in turn brings in newer versions of several key libraries, updates the minimum required Node.js version, removes some transitive dependencies, and fixes many security issues (including a critical severity vulnerability inprotobufjs).Dependency updates:
Upgraded
landofrom commitc7dd51e8to78d382fc, which updates its dependencies, including bumpingaxiosto^1.15.2,dockerodeto^5.0.0,jsonfileto^6.2.1, andlodashto^4.18.1. The minimum required Node.js version forlandois also increased from>=14.0.0to>=18.0.0. [1] [2] [3] [4]Updated direct and transitive dependencies:
axiosfrom1.14.0to1.15.2dockerodefrom4.0.12to5.0.0[1] [2]follow-redirectsfrom1.15.11to1.16.0jsonfilefrom6.2.0to6.2.1protobufjsfrom7.5.4to7.5.6, along with its dependencies:@protobufjs/codegen,@protobufjs/inquire, and@protobufjs/utf8[1] [2] [3] [4]Maintenance and cleanup:
uuid(was previously included vialando's olddockerodedependency).These changes ensure the project uses the latest compatible versions of its dependencies, improves security and compatibility, and aligns with newer Node.js requirements.