Skip to content

Fix rewrite rules for NodeInfo #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
obenland merged 1 commit into from
Jan 21, 2025
Merged

Fix rewrite rules for NodeInfo #1191

obenland merged 1 commit into from
Jan 21, 2025

Conversation

@obenland
Copy link
Member

@obenland obenland commented Jan 21, 2025

Proposed changes:

  • Add an upgrade routine that flushes rewrite rules to account for changes in 4.7.2

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • On a test site install 4.7.1 and update to 4.7.2.

@obenland obenland requested a review from a team January 21, 2025 16:15
@obenland obenland self-assigned this Jan 21, 2025
mattwiebe
mattwiebe reviewed Jan 21, 2025
View reviewed changes
mattwiebe
mattwiebe previously approved these changes Jan 21, 2025
View reviewed changes
@pfefferle pfefferle changed the base branch from trunk to v/4.7.3 January 21, 2025 16:35
@pfefferle pfefferle changed the base branch from v/4.7.3 to trunk January 21, 2025 16:36
@pfefferle pfefferle dismissed mattwiebe’s stale review January 21, 2025 16:36

The base branch was changed.

@obenland obenland merged commit 9ed81d6 into trunk Jan 21, 2025
22 checks passed
@obenland obenland deleted the add/rewrite-upgrade branch January 21, 2025 16:42
obenland added a commit that referenced this pull request Jan 21, 2025
@obenland
Fix rewrite rules for NodeInfo (#1191)
87cad5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfefferle pfefferle pfefferle approved these changes

+1 more reviewer

@mattwiebe mattwiebe mattwiebe left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@obenland obenland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@obenland @pfefferle @mattwiebe