Skip to content

Conversation

@obenland
Copy link
Member

@obenland obenland commented Jul 8, 2025

Proposed changes:

  • Renamed and inverted logic of rfc9421_is_unsupported to could_support_rfc9421 in Signature class for clarity.
  • Updated all usages and related tests to reflect the new method name and logic.

Other information:

  • Have you written new tests for your changes, if applicable?

Renamed and inverted logic of rfc9421_is_unsupported to could_support_rfc9421 in Signature class for clarity. Updated all usages and related tests to reflect the new method name and logic.
@obenland obenland requested a review from pfefferle July 8, 2025 16:05
@obenland obenland self-assigned this Jul 8, 2025
Copilot AI review requested due to automatic review settings July 8, 2025 16:05
@obenland obenland added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Jul 8, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Signature class to use a positively named method for RFC-9421 support checks and adjusts tests accordingly.

  • Renamed and inverted the logic of rfc9421_is_unsupported to could_support_rfc9421
  • Updated call sites in sign_request and the private support method
  • Adjusted tests to reflect the new method name and inverted assertions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/includes/class-test-signature.php Swapped reflections and assertions to use could_support_rfc9421
includes/class-signature.php Renamed method and inverted its return logic for clarity
Comments suppressed due to low confidence (2)

tests/includes/class-test-signature.php:640

  • [nitpick] The test method name still references rfc9421_is_unsupported. Rename it to test_could_support_rfc9421 to match the new method name.
	public function test_rfc9421_is_unsupported() {

tests/includes/class-test-signature.php:687

  • [nitpick] This test method name now mismatches the updated method. Consider renaming it to test_set_could_support_rfc9421 or similar to reflect the positive-support naming.
	public function test_set_rfc9421_unsupported() {

@obenland obenland merged commit 81940d1 into trunk Jul 8, 2025
15 checks passed
@obenland obenland deleted the update/rfc-functions branch July 8, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants