Fix undefined array key warning in Scheduler::async_batch #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a PHP warning that occurs when async_batch() is called without arguments by adding a null coalescing operator to safely check if $args[0] exists before testing if it's callable.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a PHP warning that occurs when Scheduler::async_batch() is called without arguments by adding a null coalescing operator to safely check for the existence of $args[0] before testing if it's callable.
Key Changes:
- Added null coalescing operator (
??) to prevent undefined array key warning when checking if$args[0]is callable
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| includes/class-scheduler.php | Added null coalescing operator to safely check $args[0] before is_callable() test |
| .github/changelog/2497-from-description | Added changelog entry documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pfefferle
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes:
$args[0]exists before testing if it's callable inScheduler::async_batch()Other information:
Testing instructions:
The fix prevents a PHP warning that occurs when
Scheduler::async_batch()is called without arguments:Changelog entry
Changelog Entry Details
Significance
Type
Message
Undefined array key warning in Scheduler::async_batch when called without arguments.