Remove html_entity_decode to prevent encoding issues #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tested this on content which includes MarkDown, HTML, encoded entities, unencoded entities, etc. Fixes #445
Member
|
I thinks we should add some tests here, to not break something else! I will also check why this was added in the first place. |
pfefferle
added a commit
that referenced
this pull request
Oct 2, 2023
* fix html-entity issue in username * remove kses let other platforms decide what to allow and what not * Remove html_entity_decode to prevent encoding issues (#454) I've tested this on content which includes MarkDown, HTML, encoded entities, unencoded entities, etc. Fixes #445 Co-authored-by: Matthias Pfefferle <pfefferle@users.noreply.github.com> * remove allowed tags --------- Co-authored-by: Terence Eden <edent@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445
Proposed changes:
Previously, content like
<was incorrectly converted to<- this meant that HTML elements would be passed which wouldn't render correctly.By removing this, I'm able to post content with encoded entities.
I've tested this on content which includes MarkDown, HTML, encoded entities, unencoded entities, etc.
Other information:
Testing instructions:
The new <search> element is <em>"grëát"</em> - It makes me 🥰 and 😽 - you should spend your £s on it.<search>element would be inserted and the rendering of the post would break.