Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Mentions #95

Closed
wants to merge 10 commits into from
Closed

Conversation

mediaformat
Copy link
Collaborator

@mediaformat mediaformat commented Jun 3, 2020

Work in progress for constructing a per user inbox, federating replies.

The wordpress comment system is fine for allowing Fediverse users to interact with a post, however currently Private Mentions (non-public, such as Followers Only, and Direct/Private Messages) end up as WP Comments.

The following types of mentions go to a custom Mentions Post Type

@mediaformat mediaformat changed the title [WIP] Direct Messages [WIP] Messages Sep 8, 2020
@mediaformat mediaformat changed the title [WIP] Messages [WIP] Mentions Sep 11, 2020
@mediaformat
Copy link
Collaborator Author

mediaformat commented Oct 12, 2020

Slow and steady with this, there are a lot of moving parts to test.

  • Tagging users in comments
  • Only federate comments from AP enabled post types

Unfinished business:

@pfefferle
Copy link
Member

Isn't it easier to use a custom-post-type for direct messages? It would make it easiere to list them, to update them and to comment them?

@mediaformat
Copy link
Collaborator Author

Indeed, this is what I have upstream, and will be pushing in the next few days.

Django Doucet added 3 commits December 1, 2020 01:30
* Comment-Threading-temp:
  Comments with threading
  Only federate comments from permitted post types
  maintain content warning (over activitypub) when replying to comment
  Fix comment parent threading issue
  threaded comments
  Comment threading (start of mentions)

# Conflicts:
#	activitypub.php
#	includes/class-admin.php
#	includes/rest/class-inbox.php
@mediaformat
Copy link
Collaborator Author

mediaformat commented Dec 1, 2020

Still some work to do:

  • Mention audience
  • Mention threading
  • Resolve Merge conflicts

…itypub into DirectMessages

# Conflicts:
#	includes/class-admin.php
#	includes/functions.php
#	includes/model/class-activity.php
#	includes/model/class-post.php
#	includes/rest/class-followers.php
#	includes/rest/class-following.php
#	includes/rest/class-inbox.php
#	includes/rest/class-nodeinfo.php
#	includes/rest/class-outbox.php
#	includes/rest/class-server.php
#	includes/rest/class-webfinger.php
@mediaformat
Copy link
Collaborator Author

Rebased from master. Not ready for Merge

pfefferle added a commit that referenced this pull request Dec 18, 2020
this fixes #101

direct messages will be re-added via #95
@mediaformat
Copy link
Collaborator Author

mediaformat commented Dec 29, 2020

  • do not include link from content template, or bypass outright if sending a non-public mention
  • change status for non-public mentions
  • Federate comment deletes (send, process received)
  • Verify signatures of incoming requests!

@mkljczk
Copy link
Contributor

mkljczk commented Jul 4, 2021

Has there been any recent progress on this PR?

@mediaformat
Copy link
Collaborator Author

Not so recently, however the features will be split into separate PRs in the near future.

@stale
Copy link

stale bot commented Apr 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 1, 2022
@pfefferle pfefferle added pinned and removed wontfix This will not be worked on labels Apr 1, 2022
@pfefferle
Copy link
Member

Keep!

@mediaformat mediaformat mentioned this pull request Apr 15, 2022
8 tasks
@HammyHavoc
Copy link

This looks really interesting. I think this is really the only thing stopping me from giving it a go.

As someone who hasn't really used Mastodon much but was a huge Twitter user (over 100,000 tweets), would I be able to follow and interact with people if I used this once the feature is complete? And would I be able to login to a Mastodon client via the identity of my own site?

Apologies if I'm misunderstanding the intent of the project. I know it does a fair bit.

@mediaformat
Copy link
Collaborator Author

@HammyHavoc This PR is very out of date, the work was largely ported to #142, and the remaining items will be added to a subsequent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants