Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Oct 23, 2024

It was helpful when testing my previous PR to test it out locally and wp-env was nice and simple. The AP plugin prefers a pretty permalink setting, so this adds wp-env as a "supported" local setup, including auto-setting the permalink when using npm run env-start

Proposed changes:

  • Adds .wp-env.json file.
  • Adds script to package.json to start and stop the env.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • npm install && npm run env-start does it work? Open the site (default user/pass: admin/password). Are permalinks already set?"
  • npm run env-stop does it stop?

@kraftbj
Copy link
Contributor Author

kraftbj commented Oct 23, 2024

We can probably chain things with npm run dev to auto-start the env too, but I defer to y'all who work on this daily on that one.

@kraftbj
Copy link
Contributor Author

kraftbj commented Oct 23, 2024

I also alpha-sorted .distignore just for the sake of my own brain being able to parse the list faster.

Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kraftbj

@pfefferle pfefferle merged commit a9bb170 into trunk Oct 23, 2024
21 checks passed
@pfefferle pfefferle deleted the add/wp-env-support branch October 23, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants