-
Notifications
You must be signed in to change notification settings - Fork 3
Add Support Ticket encrypted log IDs #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| // This test ensures that existing code compiles – it's not meant to run anything | ||
| struct SupportTicketsCompatTests { | ||
|
|
||
| @Test func `test ticket creation params`() async throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea you can use test ticket creation params as a function name. But it looks a bit strange, maybe just use regular function name convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't really mind it. Seems like a neat trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note: this is pretty common in Kotlin :)
3f78f1c to
ce37d0a
Compare
|
❓ Shouldn't we add the logs also to the |

Allows encrypted logs to be attached to support requests