Skip to content

Conversation

@jkmassel
Copy link
Contributor

Allows encrypted logs to be attached to support requests

// This test ensures that existing code compiles – it's not meant to run anything
struct SupportTicketsCompatTests {

@Test func `test ticket creation params`() async throws {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea you can use test ticket creation params as a function name. But it looks a bit strange, maybe just use regular function name convention?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for tests :)

It makes the test names easy to read faster than @Test("test ticket creation params") func testTicketCreationParams():

Screenshot 2025-11-19 at 4 14 47 PM

Do you still feel this way if this is only for use with Swift Testing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't really mind it. Seems like a neat trick.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: this is pretty common in Kotlin :)

@jkmassel jkmassel enabled auto-merge (squash) November 19, 2025 23:30
@jkmassel jkmassel requested a review from crazytonyli November 19, 2025 23:44
@jkmassel jkmassel force-pushed the add/support-ticket-encrypted-log-ids branch from 3f78f1c to ce37d0a Compare November 20, 2025 01:46
@jkmassel jkmassel merged commit 86b3811 into trunk Nov 20, 2025
22 checks passed
@jkmassel jkmassel deleted the add/support-ticket-encrypted-log-ids branch November 20, 2025 07:05
@adalpari
Copy link
Contributor

adalpari commented Nov 20, 2025

❓ Shouldn't we add the logs also to the addMessageToSupportConversation function as well?
I see, we added it CreateSupportTicketParams to but not to AddMessageToSupportConversationParams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants