-
Notifications
You must be signed in to change notification settings - Fork 3
Add Support Ticket encrypted log IDs #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9d603ce
Add encrypted log IDs
jkmassel c41197b
Add stability tests for support ticket APIs
jkmassel f3e21a8
Fix test identifiers
jkmassel ce37d0a
Use latest Xcode
jkmassel 4511855
Use CRL fix
jkmassel 22db29a
Use Swift 6.2 for Docker
jkmassel 3cf6f67
Use udpated OS versions
jkmassel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import WordPressAPI | ||
|
|
||
| final class AppNotifier: WpAppNotifier { | ||
| func requestedWithInvalidAuthentication(requestUrl: String) async { | ||
| // Ignore this for tests | ||
| } | ||
| } |
27 changes: 27 additions & 0 deletions
27
native/swift/Tests/api-compatibility/wpcom/SupportTickets.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import Foundation | ||
| import Testing | ||
| import WordPressAPI | ||
|
|
||
| // This test ensures that existing code compiles – it's not meant to run anything | ||
| struct SupportTicketsCompatTests { | ||
|
|
||
| @Test func `test ticket creation params`() async throws { | ||
| _ = CreateSupportTicketParams( | ||
| subject: "Hello World", | ||
| message: "Test Message", | ||
| application: "Test Suite", | ||
| wpcomSiteId: 1234, | ||
| tags: ["tag1", "tag2"], | ||
| encryptedLogIds: [UUID().uuidString] | ||
| ) | ||
| } | ||
|
|
||
| @Test func `test ticket reply params`() async throws { | ||
| _ = AddMessageToSupportConversationParams( | ||
| message: "This is a reply", | ||
| attachments: [ | ||
| "/path/to/file/on/disk" | ||
| ] | ||
| ) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea you can use
test ticket creation paramsas a function name. But it looks a bit strange, maybe just use regular function name convention?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only for tests :)
It makes the test names easy to read faster than
@Test("test ticket creation params") func testTicketCreationParams():Do you still feel this way if this is only for use with Swift Testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't really mind it. Seems like a neat trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note: this is pretty common in Kotlin :)