Fall back to OkHostnameVerifier for default SSL verification #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When allowedHostnames is configured, the custom hostname verifier doesn't fall back to default OkHttp verification. This breaks SSL verification for sites using wildcard/SAN certificates. The test demonstrates that after configuring an allowed hostname override, requests to other valid SSL sites (google.com) fail with SSL errors instead of succeeding.
The custom WpRequestExecutorHostnameVerifier now falls back to OkHostnameVerifier when the hostname is not in the allowlist. This ensures proper handling of wildcard certificates and SANs while still allowing custom hostname overrides. Changes: - Import OkHostnameVerifier from okhttp3.internal.tls - Check custom allowlist first, then fall back to default verification - Remove conditional verifier application (always use our verifier)
oguzkocer
force-pushed
the
fix-hostname-verifier-fallback
branch
from
cb009f7 to
374e87e
Compare
jkmassel
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
allowedHostnamesis configured, the custom hostname verifier now falls back toOkHostnameVerifierinstead of rejecting all other sites. This ensures wildcard/SAN certificates work while still allowing custom overrides.Test plan