Request module #108
Merged
Request module #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
approved these changes
May 23, 2024
There was a problem hiding this comment.
Looks fine!
To your question – I prefer that if we have pub struct PluginsEndpoint that the file is named plugins_endpoint.rs, but if it gets annoying we can change it later – I think the canonical argument here is that if you have them all open in the same editor it's easier to see which file is which 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #107.
Introduces
requestmodule movingWPNetworkRequest&WPNetworkResponsetypes andendpointmodule into it. No change has been made besides updating the import statements.I intend to build on this
requestmodule by splittingWPApiHelpertype.@jkmassel @crazytonyli Do you think we should remove the
endpointsuffix from theendpoint/users_endpoint.rs&endpoint/plugins_endpoint.rsfiles? Since these are within theendpointmodule, the suffix is probably unnecessary. The only issue is that we'd have multipleusers.rs,plugins.rsetc files - although all of them would be under different directories that clearly shows the distinction.