Don't export endpoint module, remove url module
#107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkocer
changed the title
url module
oguzkocer
force-pushed
the
dont-export-endpoint-module
branch
from
a970f5a to
6f2e06c
Compare
Merged
jkmassel
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #101 as I missed the re-export in
endpoint&urlmodules.Edit: I ended up merging
urlmodule intologinmodule. Both of these modules are left from the prototype. The reason it's done in this PR is because I realized we had to useuse ::url::Url;syntax in 6682e65 as we had aurlmodule and aurlcrate dependency. Removing theurlmodule was the simplest solution. We can figure out what to do with these modules at a later time.