Skip to content

Localized FetchError and CollectionError#1130

Merged
crazytonyli merged 4 commits intotrunkfrom
wp-mobile-error-messages
Jan 29, 2026
Merged

Localized FetchError and CollectionError#1130
crazytonyli merged 4 commits intotrunkfrom
wp-mobile-error-messages

Conversation

@crazytonyli
Copy link
Copy Markdown
Contributor

Localize these errors because they will be used to show error messages on UI.

@crazytonyli crazytonyli requested a review from jkmassel January 29, 2026 08:43

already_logged_in = You are already logged in as {$username}.

database_generic_message = There was a problem loading your data.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we ensure that this message always contains the underlying SQLite message? Otherwise it's pretty hard to tell what's going on if a user reports it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in f91bd8b

@crazytonyli crazytonyli enabled auto-merge (squash) January 29, 2026 21:36
@crazytonyli crazytonyli requested a review from jkmassel January 29, 2026 21:36
@crazytonyli crazytonyli merged commit b68e345 into trunk Jan 29, 2026
22 checks passed
@crazytonyli crazytonyli deleted the wp-mobile-error-messages branch January 29, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants