Extract login details improvements #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR dissects #46 and implements the Rust parts that still makes sense to include.
ParsedUrl
to be a proper wrapper aroundurl::Url
. The point of this type is to be able to expose it through FFI and this setup should allow us to do that. It adds all variants ofurl::ParseError
toParseUrlError
and aGeneric
error becauseurl::ParseError
is non-exhaustive. It adds some unit tests to test various error types - some of which is lifted from Add Login and URL Tests #46.OAuthResponseUrlError
from Add Login and URL Tests #46, updating theextract_login_details_from_url
implementation to return aResult
. Also brings in the unit tests related to this from Add Login and URL Tests #46.