Add Login and URL Tests #46
Conversation
| } | ||
| } | ||
|
|
||
| impl TryFrom<WPRestAPIURL> for url::Url { |
There was a problem hiding this comment.
I'm not sure if we want to make this a recoverable error – providing an invalid URL is a programmer error, so this should probably panic instead? But a server could also provide an invalid URL and that's not the user's fault.
Interested to hear y'alls thoughts?
There was a problem hiding this comment.
That'd be a none issue if WPRestAPIURL is guaranteed to be a valid URL, right? We can un-pub WPRestAPIURL.string_value and use a WPRestAPIURL::from_str() -> Result<WPRestAPIURL, UrlParsingError> function as the only function to create a WPRestAPIURL instance?
| }; | ||
| } | ||
|
|
||
| builder.build() //.map_err(|err| UrlParsingError::InvalidUrl) |
There was a problem hiding this comment.
IMO, the previous implementation using fold is cleaner. The build function body can be merged into this function here.
| } | ||
| } | ||
|
|
||
| impl TryFrom<WPRestAPIURL> for url::Url { |
There was a problem hiding this comment.
That'd be a none issue if WPRestAPIURL is guaranteed to be a valid URL, right? We can un-pub WPRestAPIURL.string_value and use a WPRestAPIURL::from_str() -> Result<WPRestAPIURL, UrlParsingError> function as the only function to create a WPRestAPIURL instance?
| extension OAuthResponseUrl { | ||
| static func new(stringValue: String) -> OAuthResponseUrl { | ||
| OAuthResponseUrl(stringValue: stringValue) | ||
| } |
There was a problem hiding this comment.
I didn't find any caller to this function. Can it be deleted?
|
Replaced by #163 – closing |
2 participants
Adds tests (and types) that were missing from #44, including:
WPAPIApplicationPasswordDetailsBuilderfor parsing the OAuth URLWPRestAPIURLhandling