Unit tests for UserListParams
& UserDeleteParams
#72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
UserListParams
unit tests, we use a macro to dynamically generate the test cases. This allows us to set arbitrary number of fields ofUserListParams
and validate them against given query pairs. For now, the macro lives in thetests
module, but I think we might move this into the library in a future PR as it would be useful in other places as well.I realized that there was a missing
s
inUserListParams. has_published_posts
field as I was working on the unit tests, so this PR also fixes that.Note that other parameter types don't have
query_pairs
function - or any other function for that matter - so they don't get any unit tests.Quick tip:
If you run the tests with
--nocapture
option, for example ascargo test --lib -- --nocapture
, you can see all the test cases for thetest_user_list_params
in the logs. I'll go ahead and set this option for CI, so it's visible in CI logs as well. e409d6a