Parametrize list users integration tests #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #72, this PR uses the same approach to increase our integration test coverage by using parametrized tests.
I am not sure about publishing the macro, but I think we might end up removing the
wp_networkingcrate all together and move the tests towp_apiwhich will resolve the issue. For now, this is a quick win and publishing the macro - at least for now - is harmless.The better way to do this would be through proper builder pattern, but I didn't like
derive_builderand - at this stage, we shouldn't spend time on things that won't have any added value besides syntactic sugar. Also, even the most concise builder pattern might be too verbose as arstestcase.