i18n: Update importer/upgrade-plan-details to use numberFormat for percent values in strings

[chriskmnds]

Part of addressing https://github.com/Automattic/i18n-issues/issues/949

Proposed Changes

Updates the plan-upgrade details during site importer or plan upgrade to use placeholders with numberFormat parsing for percentages in translation strings

Media

setup/import-focused?siteSlug=[site not on business] - Before/after in EN:

Why are these changes being made?

Part of addressing https://github.com/Automattic/i18n-issues/issues/949

Testing Instructions

• Go to /setup/import-focused?siteSlug=[site not on business]
• Confirm the percentages render correctly across different locales - we don't have translations yet, so the remaining strings won't be translated - per media above

props to @agrullon95 & @renatho for helping with testing

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-138697

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-138697&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-138697&env=a8c-for-agencies

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[chriskmnds]

@agrullon95 can you help me test this? I cannot seem to be able to reach the step/location where this renders. I looked through a recent PR of yours (#89497) but no luck. 🙏

[renatho]

Hi @chriskmnds! 👋

I would recommend you to check the flows to see if this step is still used, or we just forgot to remove it in a refactor. Trying to navigate quickly, I wasn't able to see the step either.

This is the pricing step I see now:

When we worked on that, we had a step similar to this one to present the pricing:

For more context, I found a PR where I worked on that old version: #90966

[agrullon95]

It seems like a lot has changed since my PR. I found this used in the migration-signup, import-focused stepper flows.

Migration-signup : /setup/migration-signup - should create site then you can enter a WP site to transfer
Import-focused: /setup/import-focused?siteSlug={NON_BUSINESS_PLAN_SITE}

[agrullon95]

@chriskmnds - This is how it looks on your branch:

Local branch (trunk):

[chriskmnds]

Oh thank you both @agrullon95 @renatho for confirming and testing! 💯 Really appreciate it

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17287201

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @chriskmnds for including a screenshot in the description! This is really helpful for our translators.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• help-center
• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/i18n-number-format-percent-importer on your sandbox.