Reader: Misc changes needed for showing feed preview while adding subscription

[mehmoodak]

Related to https://github.com/Automattic/loop/issues/478

Note: It will be helpful to review this PR commit by commit. Now there are lot of commits due to trunk merge so kindly review each commit from the description.

Proposed Changes

I've worked on the Feed Preview PR, which had grown too large so taking out independent changes that can be merged separately.

• REMOVE: sign up modal because we only show add sites form for logged our users - no screenshot

• REMOVE: useCallback hooks as it seems unnecessary - no screenshot

• IMPROVE: url validation on add sites form by allowing urls without HTTP Protocol - no screenshot

• IMPROVE: subscribe and unsubscribe mutations by adding onSuccess and onError callbacks

Before	After

• UPDATE: logic of showing follow button on discover page. Screenshot is just for reference as we are hiding this button for feed preview available on "Add New" and "Reddit" tab which doesn't exist as of now.

• IMPROVE: Makes add sites form inline throughout the app

Before	After

• REFACTOR: separate styling of subscriptions row and reader feed item - no screenshot

• ADDS: util class to avoid padding on stream - no screenshot

• REMOVE: isUserLoggedIn selector because we are only show 'Add New' and 'Reddit' tab for logged in users - no screenshot

Why are these changes being made?

To make the Feed Preview PR smaller.

Testing Instructions

• Go to /reader/subscriptions. verify subscription and unsubscription of site is working fine.
• Go to /reader/subscriptions. Open "New Subscription" modal. Verify subscription and unsubscription of the site is working fine.
• Go to /discover/add-new. Verify site can be added successfully.
• Go to /discover/add-new. Verify feeds can be added successfully.
• Go to /discover/reddit. Verify reddit feeds can be added successfully.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-137905

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-137905&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-137905&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~705 bytes removed 📉 [gzipped])

Details

name                 parsed_size           gzip_size
entry-subscriptions      -1706 B  (-0.1%)     -705 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1181 bytes removed 📉 [gzipped])

Details

name                             parsed_size           gzip_size
themes                               -1756 B  (-0.2%)     -732 B  (-0.2%)
reader                               -1084 B  (-0.0%)     -449 B  (-0.0%)
plugins                               +104 B  (+0.0%)      +66 B  (+0.0%)
jetpack-cloud-plugin-management       +104 B  (+0.0%)      +66 B  (+0.0%)
home                                  +104 B  (+0.0%)      +66 B  (+0.0%)
a8c-for-agencies-plugins              +104 B  (+0.0%)      +66 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~288 bytes added 📈 [gzipped])

Details

name                                                 parsed_size           gzip_size
async-load-design-blocks                                  +635 B  (+0.0%)     +301 B  (+0.1%)
async-load-calypso-components-web-preview-component       +635 B  (+0.1%)     +301 B  (+0.2%)
async-load-calypso-reader-discover-discover-stream         -51 B  (-0.4%)      -13 B  (-0.3%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug loop-478/show-feed-preview-before-adding-misc on your sandbox.

[DustyReagan]

Code review:

• ✅ REMOVE: sign up modal because we only show add sites form for logged our users
• ✅ REMOVE: useCallback hooks as it seems unnecessary
• ✅ IMPROVE: url validation on add sites form by allowing urls without HTTP Protocol
  • I think this is fine as is, but I wanted to highlight we also have @wordpress/url.
• ✅ IMPROVE: subscribe and unsubscribe mutations by adding onSuccess and onError callbacks
• ✅ UPDATE: logic of showing follow button on discover page.
• ✅ IMPROVE: Makes add sites form inline throughout the app
• ✅ REFACTOR: separate styling of subscriptions row and reader feed item - I'm not sure how to test this, but it looks ok.
• ✅ ADDS: util class to avoid padding on stream - I'm not sure how to test this, but it looks ok.
• ✅ REMOVE: isUserLoggedIn selector because we are only show 'Add New' and 'Reddit' tab for logged in users

Functional test:

• ✅ Go to /reader/subscriptions. verify subscription and unsubscription of site is working fine.
• ✅ Go to /reader/subscriptions. Open "New Subscription" modal. Verify subscription and unsubscription of the site is working fine.
• ✅ Go to /discover/add-new. Verify site can be added successfully.
• ✅ Go to /discover/add-new. Verify feeds can be added successfully.
• ✅ Go to /discover/reddit. Verify reddit feeds can be added successfully.

I was under the impression from the code review that I should no longer need to add a protocol to add a site? However, it looks like the form field (Firefox & Chrome) prevents that.

[mehmoodak]

Thanks for the review and thoroughly testing it.

I was under the impression from the code review that I should no longer need to add a protocol to add a site? However, it looks like the form field (Firefox & Chrome) prevents that.

This will be fixed in #101426