Skip to content

Comments

Big Sky: Redirect from /home/#101656

Merged
artpi merged 1 commit intotrunkfrom
big-sky-redirect-home
Mar 27, 2025
Merged

Big Sky: Redirect from /home/#101656
artpi merged 1 commit intotrunkfrom
big-sky-redirect-home

Conversation

@artpi
Copy link
Contributor

@artpi artpi commented Mar 20, 2025

Fixes https://github.com/Automattic/big-sky-plugin/issues/2841
Fixes BSKY-191

What it does

  • For sites that are part of ai-site-builder onboarding flow
  • And on a plan different than one of the plans with Big Sky
  • Redirect to a Big Sky modal

Testing instructions

Zrzut ekranu 2025-03-20 o 11 06 38

The big thing to test is all the sites that are NOT big sky if they are not redirecting by accident

@github-actions
Copy link

github-actions bot commented Mar 20, 2025

@artpi artpi self-assigned this Mar 20, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 20, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~159 bytes added 📈 [gzipped])

Details
name  parsed_size           gzip_size
home       +406 B  (+0.0%)     +159 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug big-sky-redirect-home on your sandbox.

@kthai15
Copy link
Contributor

kthai15 commented Mar 20, 2025

The redirect from /home works, but do we need to worry about the other calypso paths, like /themes, /plugins, etc?

@dereksmart
Copy link
Contributor

@kthai15 I think those would be caught if we did this https://github.com/Automattic/big-sky-plugin/issues/2841#issuecomment-2740638746

@kthai15
Copy link
Contributor

kthai15 commented Mar 26, 2025

I can confirm that there's no redirect on

  • sites that were created outside the ai-site-builder flow
  • sites that were created with the ai-site-builder flow but on a paid plan

If we're ok without implementing this or doing it as a followup then I think this is safe to merge

@artpi
Copy link
Contributor Author

artpi commented Mar 27, 2025

If we're ok without implementing https://github.com/Automattic/big-sky-plugin/issues/2841#issuecomment-2741609845 or doing it as a followup then I think this is safe to merge

I'm thinking we still allow /sites and block the launching on API end until you are on a paid plan

@artpi artpi merged commit 9a039f7 into trunk Mar 27, 2025
23 of 24 checks passed
@artpi artpi deleted the big-sky-redirect-home branch March 27, 2025 10:06
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants