Skip to content

Help Center: Maximize Help Center if HC icon clicked while minimized#101668

Merged
escapemanuele merged 4 commits intotrunkfrom
update/hc-maxmize-when-opening-from-masterbar
Mar 25, 2025
Merged

Help Center: Maximize Help Center if HC icon clicked while minimized#101668
escapemanuele merged 4 commits intotrunkfrom
update/hc-maxmize-when-opening-from-masterbar

Conversation

@agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Mar 20, 2025

Fixes #101323

Proposed Changes

  • Open the Help Center when the Help Center Icon is clicked while it is minimized

Why are these changes being made?

  • If the Help Center is minimized and the Help Center (?) icon is clicked, it will close instead of maximize. These changes will improve the experience for users by maximizing the Help Center instead.

Testing Instructions

  • Checkout branch
  • Navigate to apps/help-center and run yarn dev --sync
  • Sandbox the widget API
  • Go to a simple site dashboard, open the Help Center with the (?) icon minimize it, then click the Help Center (?) icon again.
  • Verify the Help Center is maximized.
  • Test the editor and wp-admin
  • Repeat the same steps with a Jetpack site.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@agrullon95 agrullon95 added the [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. label Mar 20, 2025
@agrullon95 agrullon95 requested a review from a team March 20, 2025 13:33
@agrullon95 agrullon95 self-assigned this Mar 20, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 20, 2025
@github-actions
Copy link

github-actions bot commented Mar 20, 2025

@matticbot
Copy link
Contributor

matticbot commented Mar 20, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~139 bytes added 📈 [gzipped])

Details
name           parsed_size           gzip_size
entry-main          +374 B  (+0.0%)     +152 B  (+0.0%)
entry-login         +374 B  (+0.0%)     +104 B  (+0.0%)
entry-stepper       +177 B  (+0.0%)      +91 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~307 bytes removed 📉 [gzipped])

Details
name                   parsed_size           gzip_size
site-settings               -210 B  (-0.0%)      -16 B  (-0.0%)
settings                    -210 B  (-0.0%)      -65 B  (-0.0%)
reader                      -210 B  (-0.0%)      -41 B  (-0.0%)
plugins                     -210 B  (-0.0%)      -13 B  (-0.0%)
plans                       -210 B  (-0.0%)      -18 B  (-0.0%)
patterns                    -210 B  (-0.0%)      -22 B  (-0.0%)
gutenberg-editor            -210 B  (-0.0%)      -17 B  (-0.0%)
subscribers                 -197 B  (-0.0%)      -25 B  (-0.0%)
site-blocks                 -197 B  (-0.0%)       -5 B  (-0.0%)
security                    -197 B  (-0.0%)       -5 B  (-0.0%)
purchases                   -197 B  (-0.0%)       -5 B  (-0.0%)
privacy                     -197 B  (-0.0%)       -5 B  (-0.0%)
notification-settings       -197 B  (-0.0%)       -5 B  (-0.0%)
me                          -197 B  (-0.0%)       -5 B  (-0.0%)
jetpack-app                 -197 B  (-0.0%)      -19 B  (-0.0%)
hosting                     -197 B  (-0.0%)      -51 B  (-0.0%)
home                        -197 B  (-0.0%)       -5 B  (-0.0%)
help                        -197 B  (-0.0%)       -5 B  (-0.0%)
earn                        -197 B  (-0.0%)      -25 B  (-0.0%)
developer                   -197 B  (-0.0%)       -5 B  (-0.0%)
checkout                    -197 B  (-0.0%)      -15 B  (-0.0%)
account-close               -197 B  (-0.0%)       -5 B  (-0.0%)
account                     -197 B  (-0.0%)       -5 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~189 bytes removed 📉 [gzipped])

Details
name                                                                         parsed_size           gzip_size
async-load-comment-block-editor                                                   -210 B  (-0.0%)      -41 B  (-0.0%)
async-load-automattic-global-styles-src-components-global-styles-variations       -210 B  (-0.0%)      -44 B  (-0.0%)
async-load-signup-steps-plans-theme-preselected                                   -197 B  (-0.0%)      -17 B  (-0.0%)
async-load-signup-steps-plans                                                     -197 B  (-0.0%)      -17 B  (-0.0%)
async-load-calypso-my-sites-stats-pages-subscribers                               -197 B  (-0.1%)      -35 B  (-0.1%)
async-load-async-domain-step-wrapper                                              -197 B  (-0.5%)      -35 B  (-0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Mar 20, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/hc-maxmize-when-opening-from-masterbar on your sandbox.

export const getCurrentSupportInteraction = ( state: State ) => state.currentSupportInteraction;
export const getAllowPremiumSupport = ( state: State ) => state.allowPremiumSupport;
export const getHelpCenterOptions = ( state: State ) => state.helpCenterOptions;
export const getState = ( state: State ) => state;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this now

@escapemanuele escapemanuele self-requested a review March 25, 2025 10:00
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@escapemanuele escapemanuele merged commit f7b5861 into trunk Mar 25, 2025
14 checks passed
@escapemanuele escapemanuele deleted the update/hc-maxmize-when-opening-from-masterbar branch March 25, 2025 10:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Help Center: ? should reopen the UI if minimized

3 participants

Comments