Remove style variation description on theme showcase#101677
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~200 bytes removed 📉 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
The style variation description is empty for an inactive theme or points people to the site editor on an active theme, which is redundant with the big blue Customize Site button.
c339b25 to
a87f9a5
Compare
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
The style variation description is empty for an inactive theme or points people to the site editor on an active theme, which is redundant with the big blue Customize Site button.
Related to #100354
Proposed Changes
Remove the style variation description.
Why are these changes being made?
The style variation description for the active theme links people to the site editor to make changes. This is redundant with the big blue Customize Site button.
Additionally I've removed the concept of the description altogether - the remaining case isn't possible to reach - a description isn't displayed for non-active wpcom themes, and we don't display style variations for non-wpcom themes at all. It's also redundant with other information on that page.
Here's what the description would look like if it was forced to appear:
Testing Instructions
Test using the calypso.live link below
Go to /themes without a site selected
Select a theme that has style variations
You should notice no difference between this and live
Select a free site and then go to /themes
Select a theme that has style variations
You should notice no difference between this and live
Activate the theme
Go back to the theme showcase and select the theme you just activated on the site you just activated it on.
Notice that the ‘Open the site editor to change your site’s stye’ paragraph has been removed.
Pre-merge Checklist