Skip to content

Comments

Remove style variation description on theme showcase#101677

Merged
dsas merged 1 commit intotrunkfrom
themes/update-redundant-editor-link
Mar 24, 2025
Merged

Remove style variation description on theme showcase#101677
dsas merged 1 commit intotrunkfrom
themes/update-redundant-editor-link

Conversation

@dsas
Copy link
Contributor

@dsas dsas commented Mar 20, 2025

Related to #100354

Proposed Changes

Remove the style variation description.

Why are these changes being made?

The style variation description for the active theme links people to the site editor to make changes. This is redundant with the big blue Customize Site button.

Additionally I've removed the concept of the description altogether - the remaining case isn't possible to reach - a description isn't displayed for non-active wpcom themes, and we don't display style variations for non-wpcom themes at all. It's also redundant with other information on that page.

Here's what the description would look like if it was forced to appear:

Testing Instructions

Test using the calypso.live link below

  1. Go to /themes without a site selected

  2. Select a theme that has style variations

  3. You should notice no difference between this and live

  4. Select a free site and then go to /themes

  5. Select a theme that has style variations

  6. You should notice no difference between this and live

  7. Activate the theme

  8. Go back to the theme showcase and select the theme you just activated on the site you just activated it on.

  9. Notice that the ‘Open the site editor to change your site’s stye’ paragraph has been removed.

Before After
Screenshot 2025-03-20 at 15 24 10 Screenshot 2025-03-20 at 15 24 37

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@dsas dsas self-assigned this Mar 20, 2025
@github-actions
Copy link

github-actions bot commented Mar 20, 2025

@matticbot
Copy link
Contributor

matticbot commented Mar 20, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~200 bytes removed 📉 [gzipped])

Details
name   parsed_size           gzip_size
theme       -681 B  (-0.1%)     -200 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@BogdanUngureanu BogdanUngureanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The style variation description is empty for an inactive theme or points
people to the site editor on an active theme, which is redundant with
the big blue Customize Site button.
@dsas dsas force-pushed the themes/update-redundant-editor-link branch from c339b25 to a87f9a5 Compare March 24, 2025 15:57
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug themes/update-redundant-editor-link on your sandbox.

@dsas dsas merged commit 2e80e2c into trunk Mar 24, 2025
13 checks passed
@dsas dsas deleted the themes/update-redundant-editor-link branch March 24, 2025 17:11
claudiucelfilip pushed a commit that referenced this pull request Mar 25, 2025
The style variation description is empty for an inactive theme or points
people to the site editor on an active theme, which is redundant with
the big blue Customize Site button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants