Skip to content

Fix hundred years plan flow#101788

Merged
alshakero merged 1 commit intotrunkfrom
fix/hundred-years-plan-flow
Mar 24, 2025
Merged

Fix hundred years plan flow#101788
alshakero merged 1 commit intotrunkfrom
fix/hundred-years-plan-flow

Conversation

@alshakero
Copy link
Member

@alshakero alshakero commented Mar 24, 2025

Fixes: #101776

Proposed Changes

During #101502, there was a merge conflict that I incorrectly fixed by pointing the 100-year-plan flow to the wrong flow. I wrote a script to check that all the flows are all identical before and after my PR, but it only checked the object keys, not the values. And the issue was in the value 😞

Testing Instructions

  1. Go to /setup/hundred-year-plan.
  2. Reach checkout.
  3. All should work as expected.

@github-actions
Copy link

github-actions bot commented Mar 24, 2025

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~48 bytes added 📈 [gzipped])

Details
name                   parsed_size           gzip_size
entry-stepper               +153 B  (+0.0%)      +48 B  (+0.0%)
entry-subscriptions         +119 B  (+0.0%)      +41 B  (+0.0%)
entry-main                  +119 B  (+0.0%)      +41 B  (+0.0%)
entry-login                 +119 B  (+0.0%)      +41 B  (+0.0%)
entry-domains-landing       +119 B  (+0.0%)      +41 B  (+0.0%)
entry-browsehappy           +119 B  (+0.1%)      +41 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~52129 bytes added 📈 [gzipped])

Details
name                 parsed_size              gzip_size
hundred-year-plan      +188742 B  (+9960.0%)   +51140 B  (+5139.7%)
site-migration-flow     +40346 B       (new)   +12536 B       (new)
reblogging-flow         -38453 B    (-95.3%)   -11547 B    (-92.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! thanks for the quick fix.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/hundred-years-plan-flow on your sandbox.

@alshakero alshakero merged commit 581d236 into trunk Mar 24, 2025
16 of 17 checks passed
@alshakero alshakero deleted the fix/hundred-years-plan-flow branch March 24, 2025 17:50
claudiucelfilip pushed a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix 100-year plan flow

3 participants

Comments