Skip to content

Comments

Subscribers: Navigate back to the list from the panel when a subscriber is deleted#101790

Merged
allilevine merged 1 commit intotrunkfrom
fix/subscribers-panel-close-when-deleted
Mar 24, 2025
Merged

Subscribers: Navigate back to the list from the panel when a subscriber is deleted#101790
allilevine merged 1 commit intotrunkfrom
fix/subscribers-panel-close-when-deleted

Conversation

@allilevine
Copy link
Member

@allilevine allilevine commented Mar 24, 2025

Proposed Changes

  • Navigate back to the list, instead of keeping the panel open after deleting the subscriber from the panel.

Why are these changes being made?

  • Improve UX.

Testing Instructions

  • Go to /subscribers/{site url}
  • Click on a subscriber
  • Click Delete subscriber
  • The panel should close and the deleted subscriber should no longer be on the page.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@allilevine allilevine self-assigned this Mar 24, 2025
@github-actions
Copy link

github-actions bot commented Mar 24, 2025

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~0 bytes added 📈 [gzipped])

Details
name         parsed_size           gzip_size
subscribers        +22 B  (+0.0%)       +0 B

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/subscribers-panel-close-when-deleted on your sandbox.

@allilevine allilevine marked this pull request as ready for review March 24, 2025 17:58
@allilevine allilevine merged commit fc12fcf into trunk Mar 24, 2025
15 checks passed
@allilevine allilevine deleted the fix/subscribers-panel-close-when-deleted branch March 24, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants