Reader: Update notifications panel structure and styles#101793
Reader: Update notifications panel structure and styles#101793artemiomorales wants to merge 5 commits intotrunkfrom
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~128 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
client/notifications/style.scss
Outdated
|
|
||
| .wpnc__single-view { | ||
| min-width: 410px; | ||
| } |
There was a problem hiding this comment.
I'm not sure what .wpnc__single-view does. It's just a blank div as far as I can see 🤔
Should we remove it? Or maybe it'd be better to do a separate refactor to remove obsolete things.
There was a problem hiding this comment.
This is the window that pops out when you click on a notification. Here's a screenshot below clicking the bell icon, but it's on the /reader/notifications page too. I think in this PR it's still popping out to the right of the notification, but now it's off the screen. Probably need to rework it so it pops out to the left.
There was a problem hiding this comment.
Thanks for the catch! I've reworked the PR to address this. How does it look?
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
| components: { | ||
| learnMoreLink: ( | ||
| <a | ||
| href={ localizeUrl( 'https://wordpress.com/support/third-party-cookies/' ) } |
There was a problem hiding this comment.
Does the article linked here work to provide enough context for users?
https://wordpress.com/support/third-party-cookies/
There was a problem hiding this comment.
I think a new support doc page explaining what's going on with the notification panel specifically would be better, but this doc could work in the meantime.
There was a problem hiding this comment.
Ok pushing as is sounds good, and I or someone else can follow up with a new support doc and link change.


Related to https://github.com/Automattic/loop/issues/547
Proposed Changes
Wide
Medium
Mobile
Why are these changes being made?
Testing Instructions
/reader/notificationsPre-merge Checklist