Skip to content

Comments

Reader: Update notifications panel structure and styles#101793

Closed
artemiomorales wants to merge 5 commits intotrunkfrom
update/reader-notifications-page-styles
Closed

Reader: Update notifications panel structure and styles#101793
artemiomorales wants to merge 5 commits intotrunkfrom
update/reader-notifications-page-styles

Conversation

@artemiomorales
Copy link
Contributor

@artemiomorales artemiomorales commented Mar 24, 2025

Related to https://github.com/Automattic/loop/issues/547

Proposed Changes

  • Adds HTML for a message regarding 3rd party cookies
  • Updates styles

Wide

Screenshot 2025-03-24 at 18 41 31

Medium

Screenshot 2025-03-24 at 18 41 46

Mobile

Screenshot 2025-03-24 at 18 41 57

Why are these changes being made?

  • We want to add clarity to the notifications screen

Testing Instructions

  • Visit /reader/notifications
  • Test at various widths and ensure the styles for the page look correct
  • Click around the notifications panel and make sure it still works as intended
  • Click the "Learn about 3rd party cookies" link
  • Ensure that this provides enough information for the end user

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@artemiomorales artemiomorales added the [Feature] Reader The reader site on Calypso. label Mar 24, 2025
@artemiomorales artemiomorales self-assigned this Mar 24, 2025
@github-actions
Copy link

github-actions bot commented Mar 24, 2025

@matticbot
Copy link
Contributor

matticbot commented Mar 24, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~128 bytes added 📈 [gzipped])

Details
name    parsed_size           gzip_size
reader       +417 B  (+0.0%)     +128 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.


.wpnc__single-view {
min-width: 410px;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what .wpnc__single-view does. It's just a blank div as far as I can see 🤔
Should we remove it? Or maybe it'd be better to do a separate refactor to remove obsolete things.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the window that pops out when you click on a notification. Here's a screenshot below clicking the bell icon, but it's on the /reader/notifications page too. I think in this PR it's still popping out to the right of the notification, but now it's off the screen. Probably need to rework it so it pops out to the left.

Screenshot 2025-03-25 at 10 56 08 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! I've reworked the PR to address this. How does it look?

@artemiomorales artemiomorales marked this pull request as ready for review March 24, 2025 17:54
@artemiomorales artemiomorales requested a review from a team as a code owner March 24, 2025 17:54
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 24, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/reader-notifications-page-styles on your sandbox.

components: {
learnMoreLink: (
<a
href={ localizeUrl( 'https://wordpress.com/support/third-party-cookies/' ) }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the article linked here work to provide enough context for users?
https://wordpress.com/support/third-party-cookies/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a new support doc page explaining what's going on with the notification panel specifically would be better, but this doc could work in the meantime.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pushing as is sounds good, and I or someone else can follow up with a new support doc and link change.

@Addison-Stavlo Addison-Stavlo self-assigned this Apr 4, 2025
@Addison-Stavlo
Copy link
Contributor

There are a handful of issues here to work through, I may close this and work through a separate PR.

The panel increases to full width way too early:
Screenshot 2025-04-04 at 1 24 36 PM

And there are z index issues to battle in the nested levels (items from main level bleeding through to nested level)
Screenshot 2025-04-04 at 1 24 55 PM

There are still a bit of left handed styles as well. In general, I think we should be removing a fair amount of the styles for the actual notifs panel here since its default css is baised towards what we are trying to achieve.

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Reader The reader site on Calypso.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants