Style consistency: Fix regression where it was not possible to buy domains on mobile#101794
Style consistency: Fix regression where it was not possible to buy domains on mobile#101794
Conversation
matticbot
added
the
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
zaguiini
changed the title
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
paulopmt1
left a comment
paulopmt1
left a comment
There was a problem hiding this comment.
Tested with and without the shouldUseStepContainerV2 feature flag and it's working as expected. Thanks for fixing it asap!
Should we add an e2e test for it as a follow-up?
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
I tested:
http://calypso.localhost:3000/setup/onboarding/plans?flags=-onboarding%2Fstep-container-v2 ✅
http://calypso.localhost:3000/setup/onboarding/plans ✅
I'd like to understand more about how the issue happened.
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Yes please, could you please create the follow-up issue? |
|
We changed some styles in this PR that ended up affecting both versions: the one using the old step container and the one using the new version. |
github-actions
bot
removed
the
[Status] Needs Review
…mains on mobile (#101794) * Revert our changes * Try to limit our changes to the container v2 version
4 participants
Closes #101784. Related to #101431.
Proposed Changes
Render bottom bar on mobile.
Testing instructions
With the feature flag turned on (
onboarding/step-container-v2) or off, verify you see the bottom bar when a domain is selected:Verify the page is still responsive in all viewports (mobile, tablet, desktop).