Skip to content

Comments

Onboarding Copy Polish: Update design picker subtitle#101806

Merged
vykes-mac merged 3 commits intotrunkfrom
update/design-picker-subtitle
Mar 31, 2025
Merged

Onboarding Copy Polish: Update design picker subtitle#101806
vykes-mac merged 3 commits intotrunkfrom
update/design-picker-subtitle

Conversation

@vykes-mac
Copy link
Contributor

@vykes-mac vykes-mac commented Mar 24, 2025

closes #98843
closes #98844

Proposed Changes

  • Update design picker subtitle to new copy

Why are these changes being made?

Testing Instructions

  • Go to setup/onboarding and go through to the design picker
  • Verify the copies are correct. Subtitle and Style variations

image
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@vykes-mac vykes-mac requested a review from a team March 24, 2025 22:52
@vykes-mac vykes-mac self-assigned this Mar 24, 2025
@github-actions
Copy link

github-actions bot commented Mar 24, 2025

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 24, 2025
@vykes-mac vykes-mac added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Mar 24, 2025
@matticbot
Copy link
Contributor

matticbot commented Mar 24, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/design-picker-subtitle on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Mar 24, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~58 bytes added 📈 [gzipped])

Details
name                                  parsed_size           gzip_size
async-load-automattic-design-preview       +436 B  (+1.1%)      +58 B  (+0.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new copies look good.

We can both wait for merge and remove the fallback, or add and improve fallback where needed if we want to merge asap.

'Preview our style variations for free or pick your own fonts and colors with the %(planName)s plan later on.',
{ args: { planName: getPlan( upgradeToPlan )?.getTitle() ?? '' } }
)
: translate( 'You can change your style at any time.' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're using the fallback here, can we update it to its previous text, Unlock style variations and tons of other features with the %(planName)s plan, or try them out now for free.?

Or, if we plan to keep the PR open until the translations arrive, can we remove this fallback entirely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm just string freeze and remove the fallback altogether

@a8ci18n
Copy link

a8ci18n commented Mar 25, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17314505

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @vykes-mac for including a screenshot in the description! This is really helpful for our translators.

@fditrapani
Copy link
Contributor

Thanks for making these updates! They're looking good. We have some themes that allow you to pick colours or fonts. Dropp is one of them:

image

Can we add the same blurb under the Premium styles title if you drill into one of these:
image

The same copy would work here:

Preview our style variations for free or pick your own fonts and colors with the Premium plan later on.

@vykes-mac
Copy link
Contributor Author

@fditrapani Copy added

image

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the update.

@a8ci18n
Copy link

a8ci18n commented Mar 30, 2025

Translation for this Pull Request has now been finished.

@vykes-mac vykes-mac merged commit 283e507 into trunk Mar 31, 2025
12 of 13 checks passed
@vykes-mac vykes-mac deleted the update/design-picker-subtitle branch March 31, 2025 20:27
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update copy on theme page in onboarding flow Update copy for Design Picker screen in onboarding

5 participants