Skip to content

Multi-Site: Domains: Fix alignment on large screens.#101811

Merged
StevenDufresne merged 1 commit intotrunkfrom
fix/empty-domain-state-alignment
Mar 27, 2025
Merged

Multi-Site: Domains: Fix alignment on large screens.#101811
StevenDufresne merged 1 commit intotrunkfrom
fix/empty-domain-state-alignment

Conversation

@StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented Mar 25, 2025

Related to #96626

Proposed Changes

This PR removes CSS styles that center the multi-site no domains state when the screen width is larger than 1710px.

This code was added in #96626 when the multi-site header had a max-width. It no longer does. (I couldn't find where that changed)

Before After
Screenshot 2025-03-25 at 12 01 36 PM Screenshot 2025-03-25 at 12 01 48 PM

Why are these changes being made?

It doesn't align on large desktops.

Testing Instructions

With an account with no domain on a large monitor.

  • Go to /domains/manage
  • Expect the content to be left-aligned.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Mar 25, 2025

@StevenDufresne StevenDufresne requested a review from zaguiini March 25, 2025 03:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 25, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! :shipit:

Copy link
Contributor

@zaguiini zaguiini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, with and without domains in the list.

@StevenDufresne StevenDufresne removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2025
@StevenDufresne StevenDufresne merged commit 40a5405 into trunk Mar 27, 2025
18 checks passed
@StevenDufresne StevenDufresne deleted the fix/empty-domain-state-alignment branch March 27, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments