Fix empty siteId and sessionId when leaving update-design flow#101821
Fix empty siteId and sessionId when leaving update-design flow#101821
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~39 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
paulopmt1
left a comment
There was a problem hiding this comment.
It's working as it should. Thanks for fixing it @p-jackson, and thanks for adding tests!
Fixes #101822
Proposed Changes
update-designflow from appending emptysiteIdandsessionIdquery params when it navigates to the full screen launchpadsiteIdquery params from causing a WSOD in the full screen launchpad.The fix here is that
addQueryArgs()will only ignoreundefinedvalues.nulls or empty strings get added as query args.Why are these changes being made?
This bug was introduced by #99676 when the
getPostFlowUrl()function was updated to includesessionId.CC @alshakero @agrullon95
Testing Instructions
/setup/freeCleanShot.2025-03-25.at.17.50.02.mp4
Pre-merge Checklist
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?Have you checked for TypeScript, React or other console errors?Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to DataHave we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?