Skip to content

Conversation

@tyxla
Copy link
Member

@tyxla tyxla commented Mar 25, 2025

Proposed Changes

Fixes the spacing of the Jetpack Colophon on signup/onboarding.

Part of #101825.

Why are these changes being made?

Just fixing spacing.

Testing Instructions

  • Go to /setup/newsletter/newsletterSetup
  • Verify spacing of the "Powered by Jetpack" looks good.

Screenshots

Before After
Screenshot 2025-03-25 at 13 21 06 Screenshot 2025-03-25 at 13 20 53

@tyxla tyxla added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. labels Mar 25, 2025
@tyxla tyxla requested a review from a team March 25, 2025 11:23
@tyxla tyxla self-assigned this Mar 25, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 25, 2025
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

@github-actions github-actions bot added the [Status] Design Input Requested Label automatically added to PRs where design feedback is requested label Mar 25, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/jetpack-colophon-spacing-signup on your sandbox.

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for the update.

@tyxla tyxla merged commit d9c0f57 into trunk Mar 25, 2025
15 of 16 checks passed
@tyxla tyxla deleted the fix/jetpack-colophon-spacing-signup branch March 25, 2025 11:51
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Design Input Requested Label automatically added to PRs where design feedback is requested [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants