Fix Help Center in /start when the user signs up without redirects#101843
Fix Help Center in /start when the user signs up without redirects#101843escapemanuele merged 9 commits intotrunkfrom
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
There was a problem hiding this comment.
This is moved verbatim from LayoutLoggedIn.
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~240 bytes added 📈 [gzipped]) DetailsCommon code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~46 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
escapemanuele
left a comment
There was a problem hiding this comment.
Tested and this solves the problem!
|
We've reverted this change because of p1742968249042509-slack-C02FMH4G8. |
Proposed Changes
When the user signs up without hard-redirects, the
client/controllerdoesn't have the ability to switch to the logged in layout because it is still outside React reactive cycle. What Calypso does in this case is it keeps renderingLayoutLoggedOuteven after the user logs in.LayoutLoggedOutWhy are these changes being made?
Testing Instructions