Skip to content

Comments

Site Setup: Remove unused importLight step#101845

Merged
gabrielcaires merged 1 commit intotrunkfrom
update/remove-unused-step
Mar 26, 2025
Merged

Site Setup: Remove unused importLight step#101845
gabrielcaires merged 1 commit intotrunkfrom
update/remove-unused-step

Conversation

@gabrielcaires
Copy link
Contributor

Proposed Changes

  • Remove import light step

Why are these changes being made?

  • There is no reference on Calypso, dotcom, or jetpack referencing this step, and the UI is pretty outdated.

CleanShot 2025-03-25 at 14 32 24@2x

Testing Instructions

  • Visual inspection should be enough

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gabrielcaires gabrielcaires requested a review from a team March 25, 2025 14:33
@gabrielcaires gabrielcaires requested a review from a team as a code owner March 25, 2025 14:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 25, 2025
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

@gabrielcaires gabrielcaires self-assigned this Mar 25, 2025
@gabrielcaires gabrielcaires removed the request for review from a team March 25, 2025 14:34
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~191 bytes removed 📉 [gzipped])

Details
name                   parsed_size           gzip_size
entry-stepper              -1105 B  (-0.1%)     -191 B  (-0.1%)
entry-subscriptions         -483 B  (-0.0%)     -141 B  (-0.0%)
entry-main                  -483 B  (-0.0%)     -141 B  (-0.0%)
entry-login                 -483 B  (-0.0%)     -141 B  (-0.0%)
entry-domains-landing       -483 B  (-0.1%)     -141 B  (-0.1%)
entry-browsehappy           -483 B  (-0.2%)     -141 B  (-0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~30 bytes removed 📉 [gzipped])

Details
name             parsed_size           gzip_size
reader                -350 B  (-0.0%)      -25 B  (-0.0%)
patterns              -350 B  (-0.0%)      -25 B  (-0.0%)
site-setup-flow        -17 B  (-0.0%)       -5 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~25 bytes removed 📉 [gzipped])

Details
name                                                                         parsed_size           gzip_size
async-load-comment-block-editor                                                   -350 B  (-0.0%)      -25 B  (-0.0%)
async-load-automattic-global-styles-src-components-global-styles-variations       -350 B  (-0.0%)      -25 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/remove-unused-step on your sandbox.

Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I found this additional related code that we might also be able to remove: fbhepr%2Skers%2Spnylcfb%2Spyvrag%2Soybpxf%2Svzcbeg%2Qyvtug%2S-og

@gabrielcaires gabrielcaires merged commit a7839f4 into trunk Mar 26, 2025
17 checks passed
@gabrielcaires gabrielcaires deleted the update/remove-unused-step branch March 26, 2025 14:00
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants