Posts: Navigate max pages notice to /sites#101849
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~13 bytes removed 📉 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
ciampo
left a comment
There was a problem hiding this comment.
Code changes LGTM and test well as per instructions 🚀
On trunk, the site selector opens in the sidebar, while on this PR the page navigates to /sites.
| /* eslint-disable jsx-a11y/anchor-is-valid,jsx-a11y/click-events-have-key-events,jsx-a11y/no-static-element-interactions */ | ||
| <a | ||
| className="post-type-list__max-pages-notice-link" | ||
| onClick={ this.focusSiteSelector } | ||
| /> | ||
| /* eslint-enable jsx-a11y/anchor-is-valid,jsx-a11y/click-events-have-key-events,jsx-a11y/no-static-element-interactions */ |
There was a problem hiding this comment.
Glad we moved away from this
ac9ac1d to
d855e47
Compare
Proposed Changes
Updates
PostTypeListMaxPagesNoticeto no longer set layout focus tosites, but to rather navigate to the new sites selector on/sites.I'm also using the opportunity to refactor the component to a functional one.
Why are these changes being made?
To remove one of the last instances where we're setting layout focus to
sites, which unblocks us from removing the old site picker which we're not using almost anywhere anymore.We're unifying site selection code as part of improving the multisite dashboard experience.
We're removing the old site picker in #101844 and we removed a few unused related pieces in #101835 and #101837.
Testing Instructions
remove_duplicate_views_experiment_assignment_160125preference is set tocontrol./postsPostTypeList'stotalPageCountprop to99as shown on the screenshot:/sites.